Pre-commit tweaks#820
Merged
Merged
Conversation
It's noisy, messy output. It's not of much benefit anyway as users can run git diff locally if they really need to see a diff. They have to do work locally anyway since CI won't commit the fixes pre-commit makes.
It was excluding files that are already ignored by git. Pre-commit respects git ignore, even with --all-files, so these ignores were redundant.
MarkKoz
added
t: feature
sco1
approved these changes
Mar 5, 2020
eivl
approved these changes
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed internally, showing the diff after pre-commit isn't very useful - it's just clutter. I also removed the pre-commit excludes since they are redundant.